Remove parent constructor call in CheckUsersCommand#8137
Closed
othercorey wants to merge 1 commit into5.xfrom
Closed
Remove parent constructor call in CheckUsersCommand#8137othercorey wants to merge 1 commit into5.xfrom
othercorey wants to merge 1 commit into5.xfrom
Conversation
Contributor
|
I have that in all my commands and have no problems with it. It is actually needed to create subcommands from the factory. |
Contributor
Author
You're creating commands with dependency injection? |
Contributor
|
No, but thats the reason why that call is necessary. |
Contributor
Author
|
Can you explain more? |
Contributor
Contributor
|
so the question is: What causes your exception since it shouldn't happen. |
Member
|
We should also add a note inline to why this line is here |
Contributor
Author
|
Ah, somehow I was reading a version without that defined and that's why I was confused. Also, my edit suggestion makes no sense ... I don't know why I read it that way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was removed and causes a container exception.